Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FindPythonModule #3736

Merged
merged 2 commits into from
May 27, 2020

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented May 27, 2020

This CMake module is not actually needed. Follow-up to #3656 (comment).

Use dedicated fixtures to skip tests that rely on uninstalled Python
packages instead of relying on custom CMake code.
@jngrad jngrad added the CMake label May 27, 2020
@jngrad jngrad added this to the Espresso 4.1.3 milestone May 27, 2020
@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #3736 into python will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3736   +/-   ##
======================================
  Coverage      89%     89%           
======================================
  Files         548     548           
  Lines       24455   24455           
======================================
+ Hits        21778   21779    +1     
+ Misses       2677    2676    -1     
Impacted Files Coverage Δ
src/core/particle_data.cpp 96% <0%> (+<1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b7394a...31ffa70. Read the comment docs.

@jngrad jngrad requested a review from RudolfWeeber May 27, 2020 17:55
@jngrad jngrad added the automerge Merge with kodiak label May 27, 2020
@kodiakhq kodiakhq bot merged commit 1faa7c0 into espressomd:python May 27, 2020
@jngrad jngrad deleted the cmake_remove_FindPythonModule branch January 18, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge with kodiak CMake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants