Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more globals #3738

Merged
merged 1 commit into from
May 27, 2020
Merged

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented May 27, 2020

Partial fix for #2628

@jngrad jngrad added the Core label May 27, 2020
@jngrad jngrad added this to the Espresso 4.1.3 milestone May 27, 2020
@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #3738 into python will decrease coverage by 0%.
The diff coverage is 88%.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3738   +/-   ##
======================================
- Coverage      89%     88%   -1%     
======================================
  Files         548     548           
  Lines       24455   24422   -33     
======================================
- Hits        21777   21717   -60     
- Misses       2678    2705   +27     
Impacted Files Coverage Δ
src/core/reaction_ensemble.hpp 74% <ø> (ø)
src/core/reaction_ensemble.cpp 86% <88%> (-1%) ⬇️
src/scafacos/Scafacos.cpp 77% <0%> (-15%) ⬇️
src/core/global.cpp 73% <0%> (-11%) ⬇️
src/core/grid_based_algorithms/lb.cpp 94% <0%> (-3%) ⬇️
...re/bonded_interactions/bonded_interaction_data.cpp 91% <0%> (-2%) ⬇️
src/core/electrostatics_magnetostatics/dipole.cpp 62% <0%> (-2%) ⬇️
...rc/core/electrostatics_magnetostatics/scafacos.cpp 70% <0%> (-1%) ⬇️
src/core/nonbonded_interactions/gay_berne.hpp 97% <0%> (-1%) ⬇️
src/core/electrostatics_magnetostatics/p3m.cpp 87% <0%> (-1%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1faa7c0...4b4e774. Read the comment docs.

@jngrad jngrad requested a review from fweik May 27, 2020 19:58
@jngrad jngrad added the automerge Merge with kodiak label May 27, 2020
@kodiakhq kodiakhq bot merged commit e39a7ae into espressomd:python May 27, 2020
@jngrad jngrad deleted the remove_unused_globals branch January 18, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge with kodiak Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants