Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quaternion formalism in the core and range check #3748

Merged
merged 7 commits into from
Jun 5, 2020
Merged

Quaternion formalism in the core and range check #3748

merged 7 commits into from
Jun 5, 2020

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Jun 5, 2020

Partial fix for #3713

Description of changes:

  • document quaternion formalism in the core
  • add an assertion to catch invalid square roots
  • explain that force capping doesn't affect torques
  • use vector operations

@jngrad
core: Fix literature references
e165a4b
@jngrad
core: Document quaternion formalism
6cd8681
@jngrad
core: Catch incorrect quaternion derivatives
798c3c0 
Pull out the content of the square root and check that it is
positive with an assertion. Explain in the documentation that
it can happen for very high angular velocities.
@jngrad
core: Use vector operations
ae6d7f4
@jngrad
core: Remove duplicated docs
1324b78
@jngrad
docs: Force capping limitation and alternative
b6743a5 
Force capping ignores torques while steepest descent includes them.
@jngrad jngrad added this to the Espresso 4.1.3 milestone Jun 5, 2020
@jngrad jngrad requested a review from RudolfWeeber June 5, 2020 11:42
@codecov
Copy link

codecov bot commented Jun 5, 2020 •
edited
Loading

Codecov Report

Merging #3748 into python will decrease coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3748   +/-   ##
======================================
- Coverage      89%     89%   -1%     
======================================
  Files         552     552           
  Lines       24513   24511    -2     
======================================
- Hits        21842   21831   -11     
- Misses       2671    2680    +9
Impacted Files Coverage Δ
src/core/rotation.hpp 100% <ø> (ø)
src/core/rotation.cpp 100% <100%> (ø)
src/core/polymer.cpp 92% <0%> (-7%) ⬇️
src/core/electrostatics_magnetostatics/p3m.cpp 87% <0%> (-1%) ⬇️
src/core/particle_data.cpp 96% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db92aea...1661416. Read the comment docs.

@RudolfWeeber
Copy link
Contributor

LGTM. Except that steepest descent does not cap the forces/torques but the maximum displacement in position and orientation.

RudolfWeeber
RudolfWeeber previously approved these changes Jun 5, 2020
View reviewed changes
@jngrad
Copy link
Member Author

jngrad commented Jun 5, 2020

Except that steepest descent does not cap the forces/torques

good point, I'll correct the sentence

@jngrad jngrad added the automerge Merge with kodiak label Jun 5, 2020
@kodiakhq kodiakhq bot merged commit 9fe28fe into espressomd:python Jun 5, 2020
@jngrad jngrad deleted the fixp-3713 branch January 18, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RudolfWeeber RudolfWeeber RudolfWeeber approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak Core Documentation
Projects
None yet
Milestone
Espresso 4.1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jngrad @RudolfWeeber