Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mda: extend MDAnalysis plugin by bond information. #3801

Merged
merged 4 commits into from
Jul 15, 2020
Merged

mda: extend MDAnalysis plugin by bond information. #3801

merged 4 commits into from
Jul 15, 2020

Conversation

KaiSzuttor
Copy link
Member

No description provided.

@KaiSzuttor KaiSzuttor marked this pull request as draft July 15, 2020 13:30
@codecov
Copy link

codecov bot commented Jul 15, 2020 •
edited
Loading

Codecov Report

Merging #3801 into python will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3801   +/-   ##
======================================
  Coverage      89%     89%           
======================================
  Files         554     554           
  Lines       24166   24166           
======================================
+ Hits        21562   21566    +4     
+ Misses       2604    2600    -4
Impacted Files Coverage Δ
src/core/DomainDecomposition.cpp 93% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ac81cd...3ed4013. Read the comment docs.

@KaiSzuttor KaiSzuttor marked this pull request as ready for review July 15, 2020 13:55
@jngrad jngrad self-requested a review July 15, 2020 14:38
fweik
fweik approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@fweik fweik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that there is a test now.

@jngrad jngrad added this to the Espresso 4.2 milestone Jul 15, 2020
@kodiakhq kodiakhq bot merged commit 15504b0 into espressomd:python Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jngrad jngrad jngrad approved these changes

@fweik fweik fweik approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak Python Testcase
Projects
None yet
Milestone
Espresso 4.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@KaiSzuttor @fweik @jngrad