Fix CMake warning, update macOS installation instructions #3830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes CMake warning "Unable to determine default CMAKE_INSTALL_LIBDIR directory because no target architecture is known. Please enable at least one language before including GNUInstallDirs.".
Running `sudo xcodebuild -license accept` after `sudo xcode-select --install` causes an error.
KaiSzuttor
reviewed
Jul 28, 2020
mkuron
suggested changes
Jul 28, 2020
KaiSzuttor
approved these changes
Jul 28, 2020
|
Do you really think it's a good idea to leave people on their own in installing Homebrew or MacPorts? Not everyone knows how to do that and their own install instructions can be intimidating to novice users. |
|
@mkuron I was not able to follow the MacPorts installation instructions in our user guide, the terminal threw an error. Even after you explained to me how the second command was only relevant to Xcode installed from the App Store, I still misunderstood what the command really did. The official MacPorts installation instructions explain why |
jngrad
added a commit
to jngrad/espresso
that referenced
this pull request
Aug 18, 2020
Description of changes: - fix `GNUInstallDirs`-related warning generated in CMake 3.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
GNUInstallDirs-related warning generated in CMake 3.18