Remove option_if_available() #4112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The feature is no longer necessary and leads to convoluted conditional branches. It also causes confusing behavior: the state of the options is persistent (re-running CMake without first clearing the build directory leads to a different behavior compared to running CMake in a fresh build directory), it's not always clear what will be installed, and the CMake log contains irrelevant messages about libraries not found for features that were not selected by the user. This reverts commit 4f280f6.
jngrad
force-pushed
the
remove_option_if_available
branch
from
7578a79
to
f251261
Compare
KaiSzuttor
reviewed
Feb 11, 2021
KaiSzuttor
previously approved these changes
Feb 11, 2021
KaiSzuttor
approved these changes
Feb 11, 2021
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the CMake logic less brittle and more maintainable by removing the
option_if_available()function. The user now needs to explicitly state which features or libraries have to be included in ESPResSo.