Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hollowconical Frustum with cutout #4179

Merged
merged 15 commits into from
Apr 7, 2021
Merged

Hollowconical Frustum with cutout #4179

merged 15 commits into from
Apr 7, 2021

Conversation

christophlohrmann
Copy link
Contributor

Fixes #4172

Description of changes:

  • add central_angle option to HollowConicalFrustum
  • change axis and center to CylindricalTransformationParameters for HCF
  • more default behaviour for CylindricalTransformationParameters

@KaiSzuttor
Copy link
Member

please check the shape unit test

KaiSzuttor
KaiSzuttor approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@KaiSzuttor KaiSzuttor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @christophlohrmann, I think this version has made quite an improvement to the readability

@KaiSzuttor KaiSzuttor added the automerge Merge with kodiak label Apr 7, 2021
@kodiakhq kodiakhq bot merged commit 8a2a79a into espressomd:python Apr 7, 2021
@jngrad jngrad added this to the Espresso 4.2 milestone Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaiSzuttor KaiSzuttor KaiSzuttor approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak
Projects
None yet
Milestone
Espresso 4.2.0
Development

Successfully merging this pull request may close these issues.

Add central angle option to HollowConicalFrustum shape
3 participants
@christophlohrmann @KaiSzuttor @jngrad