Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize python package version specifiers #4709

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Apr 18, 2023

Description of changes:

  • fix import errors in several tests, tutorials and benchmarks due to API changes in setuptools >= 67.3.0

Starting with setuptools v67.3.0, the pkg_resources module is being
progressively phased out from the setuptools main module.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jngrad jngrad marked this pull request as draft April 18, 2023 09:02
@jngrad jngrad force-pushed the setuptools branch 2 times, most recently from 88740e5 to 111283a Compare April 18, 2023 09:17
@jngrad jngrad marked this pull request as ready for review April 18, 2023 09:37
@jngrad jngrad added this to the Espresso 4.3.0 milestone Apr 18, 2023
@jngrad jngrad requested a review from reinaual April 18, 2023 09:37
@jngrad
Copy link
Member Author

jngrad commented Apr 18, 2023

Some Linux distros already have a version of setuptools that is too recent for ESPResSo, e.g. openSUSE Factory is failing the x86_64 pipeline in python3-espressomd.

@jngrad
Copy link
Member Author

jngrad commented Apr 18, 2023

Patch submitted to Fedora (rawhide and f38) and openSUSE (request 1080111).

@jngrad jngrad added the automerge Merge with kodiak label Apr 18, 2023
@kodiakhq kodiakhq bot merged commit d22c24b into espressomd:python Apr 18, 2023
@jngrad jngrad deleted the setuptools branch April 18, 2023 12:04
@jngrad jngrad modified the milestones: ESPResSo 4.3.0, ESPResSo 4.2.2 May 26, 2023
jngrad pushed a commit to jngrad/espresso that referenced this pull request Jul 13, 2023
Description of changes:
- fix import errors in several tests, tutorials and benchmarks due to API changes in setuptools >= 67.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants