Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for recent compilers #4715

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Add support for recent compilers #4715

merged 3 commits into from
Apr 27, 2023

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Apr 26, 2023

Description of changes:

  • fix compiler diagnostics from Clang 16.0.0 and GCC 13.0
  • reduce the amount of -Wconversion diagnostics

@jngrad
core: Fix Clang-Tidy 16.0.0 diagnostics
6561692 
Addressed modernize-use-emplace, readability-simplify-boolean-expr,
clang-diagnostic-logical-op-parentheses.
@jngrad jngrad marked this pull request as ready for review April 26, 2023 17:15
@jngrad
Copy link
Member Author

jngrad commented Apr 26, 2023

This is the work that helped me detect the LB inertialess tracers bug. I concentrated my efforts on the -Wconversion from header files, which flood the terminal, and tried to avoid LB/EK/FFT, since we have concrete plans to replace them.

The DP3M memcpy issue was likely a false positive due to the default compile-time value of 0 for cao, which could trick the -Warray-bounds heuristic into thinking std::copy would copy null bytes from an empty span.

@jngrad jngrad added this to the Espresso 4.3.0 milestone Apr 26, 2023
@jngrad jngrad requested a review from reinaual April 26, 2023 17:31
jngrad
jngrad commented Apr 26, 2023
View reviewed changes
Copy link
Member Author

@jngrad jngrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the -Warray-bounds fix was submitted to the Fedora package, where the issue was originally reported
  • all -Wconversion diagnostics from the walberla bridge and kernels have been addressed in the walberla branch (e847d71, be6c733)

@jngrad jngrad added the automerge Merge with kodiak label Apr 27, 2023
@kodiakhq kodiakhq bot merged commit 9744eb6 into espressomd:python Apr 27, 2023
@jngrad jngrad deleted the maintenance branch April 27, 2023 14:50
@jngrad jngrad modified the milestones: ESPResSo 4.3.0, ESPResSo 4.2.2 May 26, 2023
jngrad pushed a commit to jngrad/espresso that referenced this pull request Jul 13, 2023
@kodiakhq @jngrad
Add support for recent compilers (espressomd#4715)
b8b278f 
Description of changes:
- fix compiler diagnostics from Clang 16.0.0 and GCC 13.0
- reduce the amount of `-Wconversion` diagnostics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reinaual reinaual reinaual approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak CodeQuality Core
Projects
None yet
Milestone
ESPResSo 4.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jngrad @reinaual