Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI reports #4736

Merged
merged 2 commits into from
May 24, 2023
Merged

Fix CI reports #4736

merged 2 commits into from
May 24, 2023

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented May 24, 2023

Fixes #4735

Description of changes:

  • fix the URL in the GitHub CI report (new GitLab routing system)
  • provide a useful error message when the sigint test times out

The CI pipeline page requires a dash separator since GitLab 16.0.
When the sigint subprocess raises a Python exception (e.g. due to
missing features), the process remains open indefinitely, which
causes the unit test to time out and the Python interpreter to
terminate while the subprocess pipe is still open.
@jngrad jngrad added the DevOps label May 24, 2023
@jngrad jngrad added this to the Espresso 4.3.0 milestone May 24, 2023
@jngrad jngrad requested a review from reinaual May 24, 2023 12:12
@jngrad jngrad added the automerge Merge with kodiak label May 24, 2023
@kodiakhq kodiakhq bot merged commit 1f6daf7 into espressomd:python May 24, 2023
@jngrad jngrad deleted the fix-4735 branch May 24, 2023 13:21
@jngrad jngrad modified the milestones: Espresso 4.3.0, ESPResSo 4.2.2 May 26, 2023
jngrad pushed a commit to jngrad/espresso that referenced this pull request Jul 13, 2023
Fixes espressomd#4735

Description of changes:
- fix the URL in the GitHub CI report (new GitLab routing system)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge with kodiak DevOps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to new GitLab routing system
2 participants