[ELITERT-1221] Fix crashes with GitHub hosted repos #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue that caused Dragnet to crash when generating an HTML report for the results of an execution over a repository hosted on Github. The reason for the crash was that Ruby's URI parser is incapable of parsing a GitHub URL, so, it was replaced by Git's URL.parse method, which is capable of doing it.
sergio-bobillier
force-pushed
the
sb-fix-crash-with-github-repos
branch
from
1601505 to
350488c
Compare
sheputis
approved these changes
Dec 12, 2024
albertoberto
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue that caused Dragnet to crash when generating an HTML report for the results of an execution over a repository hosted on Github.
The reason for the crash was that Ruby's URI parser is incapable of parsing a GitHub URL, so, it was replaced by Git's
URL.parsemethod, which is capable of doing it.