Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ELITERT-1198] Add action to generate the Sphinx doc #2

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

sergio-bobillier
Copy link
Collaborator

@sergio-bobillier sergio-bobillier commented Oct 30, 2024

This action is equivalent to the documentation Jenkins job the project used to have. It does the following:

  • Generates the YARD documentation
  • Converts the CHANGELOG.md to Sphinx.
  • Generates the Sphinx documentation.
  • Uploads the artifact
  • Deploys the artifact to Github pages.

It only does this once changes are merged to master, just like the Jenkins job did.

branches: [ "master" ]
pull_request:
branches: [ "master" ]
# paths: [ "documentation/**"]
Copy link
Collaborator

@sheputis sheputis Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assume you meant to generate the documentation only when doc files are changed? And you had commented this out to test the pipelines?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. You were actually too early. I was just testing the action.
There seems to be no easy way to test these things, you just need to crate the action in such a way that it runs for your Pull Requests and when when ready set-up the triggers properly.

Copy link
Collaborator

@sheputis sheputis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor detail

This action is equivalent to the documentation Jenkins job the project
used to have. It does the following:

* Generates the YARD documentation
* Converts the CHANGELOG.md to Sphinx.
* Generates the Sphinx documentation.
* Uploads the artifact
* Deploys the artifact to Github pages.

It only does this once changes are merged to master, just like the
Jenkins job did.
@sergio-bobillier sergio-bobillier merged commit 7f5b7ab into master Oct 30, 2024
1 check passed
@sergio-bobillier sergio-bobillier deleted the sb-sphinx-doc branch October 30, 2024 16:51
@sergio-bobillier sergio-bobillier restored the sb-sphinx-doc branch October 31, 2024 16:12
@sergio-bobillier sergio-bobillier deleted the sb-sphinx-doc branch October 31, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants