Bump toml from 0.8.8 to 0.8.13 #1132
clippy
2 errors, 2 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 2 |
| Warning | 2 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.78.0 (9b00956e5 2024-04-29)
- cargo 1.78.0 (54d8815d0 2024-03-26)
- clippy 0.1.78 (9b00956 2024-04-29)
Annotations
Check failure on line 209 in northstar-runtime/src/npk/manifest/mod.rs
github-actions / clippy
direct implementation of `ToString`
error: direct implementation of `ToString`
--> northstar-runtime/src/npk/manifest/mod.rs:201:1
|
201 | / impl ToString for Manifest {
202 | | #[allow(clippy::unwrap_used)]
203 | | fn to_string(&self) -> String {
204 | | // A `Manifest` is convertible to `String` as long as its implementation of `Serialize` does
... |
208 | | }
209 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
Check failure on line 171 in northstar-runtime/src/common/version.rs
github-actions / clippy
direct implementation of `ToString`
error: direct implementation of `ToString`
--> northstar-runtime/src/common/version.rs:167:1
|
167 | / impl ToString for VersionReq {
168 | | fn to_string(&self) -> String {
169 | | self.inner.to_string()
170 | | }
171 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
note: the lint level is defined here
--> northstar-runtime/src/lib.rs:5:5
|
5 | clippy::all,
| ^^^^^^^^^^^
= note: `#[deny(clippy::to_string_trait_impl)]` implied by `#[deny(clippy::all)]`
Check warning on line 6 in northstar-runtime/src/runtime/ipc/raw_fd_ext.rs
github-actions / clippy
method `is_nonblocking` is never used
warning: method `is_nonblocking` is never used
--> northstar-runtime/src/runtime/ipc/raw_fd_ext.rs:6:8
|
4 | pub trait RawFdExt: AsRawFd {
| -------- method in this trait
5 | /// Returns true of self is set to non-blocking.
6 | fn is_nonblocking(&self) -> Result<bool>;
| ^^^^^^^^^^^^^^
Check warning on line 34 in northstar-runtime/src/runtime/devicemapper/data_model.rs
github-actions / clippy
associated items `from_slice`, `read_from_prefix`, `from_reader`, and `as_mut_slice` are never used
warning: associated items `from_slice`, `read_from_prefix`, `from_reader`, and `as_mut_slice` are never used
--> northstar-runtime/src/runtime/devicemapper/data_model.rs:34:8
|
25 | pub unsafe trait DataInit: Copy + Send + Sync {
| -------- associated items in this trait
...
34 | fn from_slice(data: &[u8]) -> Option<&Self> {
| ^^^^^^^^^^
...
55 | fn read_from_prefix(data: &[u8]) -> Option<Self> {
| ^^^^^^^^^^^^^^^^
...
88 | fn from_reader<R: io::Read>(mut read: R) -> io::Result<Self> {
| ^^^^^^^^^^^
...
118 | fn as_mut_slice(&mut self) -> &mut [u8] {
| ^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default