Remove enums and strictly replace them with unions #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammadfawaz
force-pushed
the
mohammadfawaz/remove_enum
branch
6 times, most recently
from
6d5d094
to
271ce49
Compare
mohammadfawaz
force-pushed
the
mohammadfawaz/remove_enum
branch
from
271ce49
to
6202ad8
Compare
mohammadfawaz
force-pushed
the
mohammadfawaz/remove_enum
branch
from
6202ad8
to
bfb31f7
Compare
mohammadfawaz
commented
Oct 4, 2024
Comment on lines
+401
to
+404
| let is_enumeration_union = Type::Union { | ||
| path: ty_path.clone(), | ||
| span: empty_span(), | ||
| } |
There was a problem hiding this comment.
Creating the type like this from ty_path is not great and I think we're doing that somewhere else already so I did the same... but that should be improved.
There was a problem hiding this comment.
Yep, I'm keen now to have the union decls referred to by slotmap key instead of the crappy string matching the Custom types (and similar) do now.
otrho
previously approved these changes
Oct 7, 2024
otrho
force-pushed
the
mohammadfawaz/remove_enum
branch
from
3c08b8d
to
57c640f
Compare
otrho
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #858