Fix password in xml body #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 3.0.2
Improve GitHub Actions workflows
Version 3.0.3
Workflows improvements
- Add a `password` struct to `UserAttributes` - Add a `Login` function to `API` for user authentication Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
feat: add user authentication functionality to API
Revert "feat: add user authentication functionality to API"
Version 3.1.0
Version 3.2.0
Version 3.2.1
Version 3.2.2
andyone
requested changes
Aug 20, 2024
| @@ -121,11 +121,11 @@ func (api *API) GetUser(userName string, withAttributes bool) (*User, error) { | |||
| // Login attempts to authenticate a user with the given username and password. | |||
| // It constructs a URL with the given username and sends a POST request to the usermanagement authentication API with the provided password. | |||
| // It returns a pointer to a User object with the user's information on successful authentication, or an error if authentication failed or an unknown error occurred. | |||
| func (api *API) Login(userName, password string) (*User, error) { | |||
| func (api *API) Login(userName, passWord string) (*User, error) { | |||
There was a problem hiding this comment.
This change is unrelated to the issue, please do not change the naming of function arguments.
There was a problem hiding this comment.
Sure, but the argument password is same with type password struct, and it should be same form with userName.
|
Hi! Thank you for your contribution. Please take a look at the review comments. |
This was referenced Aug 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As crowd api shows, the request body should be
instead of