Skip to content

Commit

Permalink
add value valuesAreBase64Encoded to indicate whether secret values ar…
Browse files Browse the repository at this point in the history
…e already encoded (#20)
  • Loading branch information
JorritSalverda authored Nov 11, 2019
1 parent a38c583 commit 227d578
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .estafette.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ version:
semver:
major: 1
minor: 2
patch: 1
patch: 2
labelTemplate: '{{branch}}-{{auto}}'
releaseBranch: 1.2.1
releaseBranch: 1.2.2

stages:
build-lint-and-package:
Expand Down
4 changes: 4 additions & 0 deletions helm/estafette-gke-node-pool-shifter/templates/secret.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,9 @@ metadata:
type: Opaque
{{- if not .Values.secret.useGcpServiceAccountAnnotation }}
data:
{{- if .Values.valuesAreBase64Encoded }}
service-account-key.json: {{.Values.secret.googleServiceAccountKeyfileJson | toString}}
{{- else }}
service-account-key.json: {{.Values.secret.googleServiceAccountKeyfileJson | toString | b64enc}}
{{- end }}
{{- end }}
3 changes: 3 additions & 0 deletions helm/estafette-gke-node-pool-shifter/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ nodePoolTo: node-pool-b
nodePoolFromMinNode: 0

secret:
# if set to true the values are already base64 encoded when provided, otherwise the template performs the base64 encoding
valuesAreBase64Encoded: false

# when using estafette-gcp-service account controller to fetch key files, set this to true and leave googleServiceAccountKeyfileJson empty
useGcpServiceAccountAnnotation: false

Expand Down

0 comments on commit 227d578

Please sign in to comment.