Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor logging to use trace instead of debug #15

Closed
estahn opened this issue Dec 16, 2020 · 3 comments
Closed

Refactor logging to use trace instead of debug #15

estahn opened this issue Dec 16, 2020 · 3 comments
Assignees
@estahn
Labels
enhancement New feature or request released on @alpha released on @beta released
Milestone
1.0.0

Comments

@estahn
Copy link
Owner

estahn commented Dec 16, 2020

Some logging is too verbose and should go to tracing.
@estahn estahn added this to the 1.0.0 milestone Dec 16, 2020
@estahn estahn added the enhancement New feature or request label Dec 16, 2020
@estahn estahn closed this as completed in ae47bd3 Dec 16, 2020
estahn added a commit that referenced this issue Dec 17, 2020
@estahn
fix: trace for verbose logs and improve context
58e05dc 
Certain logs are more verbose and are not necessarily required for
debugging, hence introducing trace.

Logs now contain more details about the AdmissionReview request, such
as UID, Kind, Name and Namespace.

fixes #15
github-actions bot pushed a commit that referenced this issue Dec 18, 2020
@semantic-release-bot
chore(release): 1.0.0-alpha.1 [skip ci]
a88c136 
# 1.0.0-alpha.1 (2020-12-18)

### Bug Fixes

* **chart:** serviceaccount missing annotation tag ([#21](#21)) ([7164626](7164626))
* trace for verbose logs and improve context ([58e05dc](58e05dc)), closes [#15](#15)

### Features

* helm chart ([00f6b74](00f6b74))
* POC ([fedcb22](fedcb22))
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Repository owner deleted a comment from github-actions bot Dec 18, 2020
@estahn estahn removed the released label Dec 18, 2020
estahn pushed a commit that referenced this issue Dec 20, 2020
@semantic-release-bot @estahn
chore(release): 1.0.0-alpha.1 [skip ci]
93bc342 
# 1.0.0-alpha.1 (2020-12-18)

### Bug Fixes

* **chart:** serviceaccount missing annotation tag ([#21](#21)) ([7164626](7164626))
* trace for verbose logs and improve context ([58e05dc](58e05dc)), closes [#15](#15)

### Features

* helm chart ([00f6b74](00f6b74))
* POC ([fedcb22](fedcb22))
github-actions bot pushed a commit that referenced this issue Dec 21, 2020
@semantic-release-bot
chore(release): 1.0.0-alpha.1 [skip ci]
4701bf8 
# 1.0.0-alpha.1 (2020-12-21)

### Bug Fixes

* **chart:** serviceaccount missing annotation tag ([#21](#21)) ([7164626](7164626))
* trace for verbose logs and improve context ([58e05dc](58e05dc)), closes [#15](#15)

### Features

* helm chart ([00f6b74](00f6b74))
* POC ([fedcb22](fedcb22))
github-actions bot pushed a commit that referenced this issue Dec 21, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
bee5b62 
# 1.0.0-beta.1 (2020-12-21)

### Bug Fixes

* hardcoded AWS region ([3cc0d49](3cc0d49)), closes [#20](#20) [#17](#17)
* **chart:** serviceaccount missing annotation tag ([#21](#21)) ([7164626](7164626))
* trace for verbose logs and improve context ([58e05dc](58e05dc)), closes [#15](#15)

### Features

* helm chart ([00f6b74](00f6b74))
* POC ([fedcb22](fedcb22))
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

estahn pushed a commit that referenced this issue Dec 25, 2020
@semantic-release-bot @estahn
chore(release): 1.0.0-beta.1 [skip ci]
00f0d7b 
# 1.0.0-beta.1 (2020-12-21)

### Bug Fixes

* hardcoded AWS region ([3cc0d49](3cc0d49)), closes [#20](#20) [#17](#17)
* **chart:** serviceaccount missing annotation tag ([#21](#21)) ([7164626](7164626))
* trace for verbose logs and improve context ([58e05dc](58e05dc)), closes [#15](#15)

### Features

* helm chart ([00f6b74](00f6b74))
* POC ([fedcb22](fedcb22))
github-actions bot pushed a commit that referenced this issue Dec 25, 2020
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
c0f97e8 
# 1.0.0 (2020-12-25)

### Bug Fixes

* bump skopeo from 0.2.0 to 1.2.0 ([84025aa](84025aa))
* hardcoded AWS region ([3cc0d49](3cc0d49)), closes [#20](#20) [#17](#17)
* **chart:** serviceaccount missing annotation tag ([#21](#21)) ([7164626](7164626))
* trace for verbose logs and improve context ([58e05dc](58e05dc)), closes [#15](#15)

### Features

* allow filters for container context ([37d0a4d](37d0a4d)), closes [#32](#32)
* automatic token renewal before expiry ([a7c45b8](a7c45b8)), closes [#31](#31)
* helm chart ([00f6b74](00f6b74))
* ImageSwapPolicy defines the mutation strategy used by the webhook. ([9d61659](9d61659))
* POC ([fedcb22](fedcb22))
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@estahn estahn self-assigned this Dec 25, 2020
rattboi added a commit to rattboi/k8s-image-swapper that referenced this issue May 6, 2022
@rattboi
Fix docker references with both tag and digest
e386f43 
fix estahn#15

This solution is taken almost directly from CRI-O, as referenced here: https://github.com/cri-o/cri-o/pull/3060/files
rattboi added a commit to rattboi/k8s-image-swapper that referenced this issue May 6, 2022
@rattboi
Fix docker references with both tag and digest
9a5df4f 
fix estahn#15

This solution is taken almost directly from CRI-O, as referenced here: https://github.com/cri-o/cri-o/pull/3060/files
@rattboi rattboi mentioned this issue May 6, 2022
Merged
rattboi added a commit to rattboi/k8s-image-swapper that referenced this issue May 6, 2022
@rattboi
Fix docker references with both tag and digest
2612343 
fix estahn#15

This solution is taken almost directly from CRI-O, as referenced here: https://github.com/cri-o/cri-o/pull/3060/files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@estahn estahn

Labels
enhancement New feature or request released on @alpha released on @beta released
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@estahn