Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Google Artifact Registry as target #447

Merged

Conversation

kjvellajr
Copy link
Contributor

Initial implementation to support Google Artifact Registry as a target registry. I have tested this with a GCP account on GKE using Workload Identity (Google's version of IRSA).

Please let me know if there are any tweaks or changes that can be done to make this align with the project direction.

closes #296

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 25, 2023
cmd/root.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
docs/configuration.md Outdated Show resolved Hide resolved
docs/getting-started.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -2.87 ⚠️

Comparison is base (0a01de7) 67.34% compared to head (9efbc9f) 64.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
- Coverage   67.34%   64.48%   -2.87%     
==========================================
  Files           6        6              
  Lines         392      366      -26     
==========================================
- Hits          264      236      -28     
- Misses        103      107       +4     
+ Partials       25       23       -2     
Impacted Files Coverage Δ
pkg/config/config.go 0.00% <ø> (ø)
pkg/types/types.go 68.96% <0.00%> (-31.04%) ⬇️
pkg/webhook/image_swapper.go 62.06% <66.66%> (-0.18%) ⬇️
pkg/webhook/image_copier.go 73.68% <100.00%> (-0.90%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kjvellajr kjvellajr force-pushed the support-google-artifact-registry-as-target branch 8 times, most recently from 5a2340a to d80dca9 Compare February 1, 2023 15:20
@kjvellajr kjvellajr force-pushed the support-google-artifact-registry-as-target branch from d80dca9 to 5d40089 Compare February 17, 2023 14:25
@bygui86
Copy link

bygui86 commented Mar 13, 2023

any update guys?

@estahn estahn changed the title feat: support google artifact registry as target Support Google Artifact Registry as target Mar 14, 2023
@estahn estahn merged commit 934d2d9 into estahn:main Mar 14, 2023
@bygui86
Copy link

bygui86 commented Mar 14, 2023

amazing guys!! thanks a lot for the effort!!
when do you plan to release this?

@estahn
Copy link
Owner

estahn commented Mar 14, 2023

when do you plan to release this?

There is an automated monthly release cycle in place. If required there can also b an earlier release. I'm waiting for #394 to be finalised and ideally also #361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support google artifact registry as target
3 participants