Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates on Chi squared and Lower incomplete gamma function #122

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Updates on Chi squared and Lower incomplete gamma function #122

merged 2 commits into from
Jan 24, 2024

Commits on Jan 22, 2024

  1. feat: Calculate CDF for Xi square using a special case when df = 2. 

    This change introduces the calculation of the CDF for the xi square
distribution by executing the special case when the degrees of
freedom is 2. This is to make it on par with calculations made in R
and some python packages. It derived from work made by @oliver-czulo
in #115.
    @estebanz01
    estebanz01 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    df07ada View commit details
    Browse the repository at this point in the history

  2. fix: Always use at least 10_000 iterations when calculating lower gamma. 

    This change fixes a small bug where we were calculating the
lower incomplete gamma function via simpson's rule with lower
than 10_000 iterations, which is not ideal. This was found while
doing some debugging on #115.
    @estebanz01
    estebanz01 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    0ed5c05 View commit details
    Browse the repository at this point in the history