Skip to content

Commit

Permalink
fix new linter warnings as of flake8-comprehensions 3.1.0 (ros2#94)
Browse files Browse the repository at this point in the history
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
  • Loading branch information
dirk-thomas authored Nov 15, 2019
1 parent c49183c commit 25a4a39
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion launch_ros/launch_ros/utilities/normalize_parameters.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def normalize_parameter_dict(
if _prefix:
# Prefix name if there is a recursive dictionary
# weird looking logic to combine into one list to appease mypy
combined = [e for e in _prefix]
combined = list(_prefix)
combined.append(TextSubstitution(text='.'))
combined.extend(name)
name = combined
Expand Down
2 changes: 1 addition & 1 deletion launch_testing_ros/launch_testing_ros/tools/output.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def get_rmw_output_filter(rmw_implementation, filter_type):

# Treat each line of the resource as an independent filter.
rmw_output_filter, _ = ament_index_python.get_resource(resource_name, rmw_implementation)
return [l for l in rmw_output_filter.splitlines()]
return rmw_output_filter.splitlines()


def basic_output_filter(
Expand Down

0 comments on commit 25a4a39

Please sign in to comment.