Added tests with optional chaining as a part of NewExpression callee

estools · Aug 5, 2020 · f672353 · f672353
1 parent 2782a3e
commit f672353
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 4 deletions.
diff --git a/escodegen.js b/escodegen.js
@@ -1897,8 +1897,11 @@
         },
 
         ChainExpression: function (expr, precedence, flags) {
-            var expression = expr.expression;
-            var result = this[expression.type](expression, precedence, flags);
+            if (Precedence.OptionalChaining < precedence) {
+                flags |= F_ALLOW_CALL;
+            }
+
+            var result = this.generateExpression(expr.expression, Precedence.OptionalChaining, flags);
 
             return parenthesize(result, Precedence.OptionalChaining, precedence);
         },

diff --git a/test/compare-acorn-es2020/optional-chaining.expected.js b/test/compare-acorn-es2020/optional-chaining.expected.js
@@ -40,4 +40,8 @@ a?.b.c();
 (a?.b.c)();
 a.b?.().c;
 (a.b?.()).c;
-(a.b?.())?.c;
+(a.b?.())?.c;
+new (a?.b().c)();
+new (a?.b())();
+new (a?.b().c)();
+new (a?.b())();
diff --git a/test/compare-acorn-es2020/optional-chaining.expected.min.js b/test/compare-acorn-es2020/optional-chaining.expected.min.js
diff --git a/test/compare-acorn-es2020/optional-chaining.js b/test/compare-acorn-es2020/optional-chaining.js
@@ -41,3 +41,7 @@ a?.b.c();
 a.b?.().c;
 (a.b?.()).c;
 (a.b?.())?.c;
+new (a?.b().c);
+new (a?.b());
+new (a?.b().c)();
+new (a?.b())();