Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown node type AssignmentPattern because estraverse is oudated #229

Closed
snowmantw opened this issue Apr 21, 2015 · 2 comments
Closed

Unknown node type AssignmentPattern because estraverse is oudated #229

snowmantw opened this issue Apr 21, 2015 · 2 comments
Assignees
@Constellation

Comments

@snowmantw
Copy link

While estraverse already supported it, escodegen couldn't update the package (current in package.json is 1.9.1) without patch. I've tried to upgrade the package but escodegen would throw an error, as TypeError: undefined is not a function.
@Constellation Constellation self-assigned this Apr 21, 2015
@pgilad
Copy link
Contributor

pgilad commented Jun 18, 2015

Need to implement support for AssignmentPattern

@ianwjhalliday
Copy link

Howdy. Is this planned to be merged in sometime soon?

Constellation added a commit that referenced this issue Jan 3, 2016
@Constellation
Merge pull request #255 from tolmasky/master
556408d 
Fix for supporting AssignmentPattern. Closes #229.
ArtemGovorov pushed a commit to wallabyjs/escodegen that referenced this issue May 18, 2016
@tolmasky @ArtemGovorov
Fix for supporting AssignmentPattern. Closes estools#229.
25743be 
Reviewed by @tolmasky.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Constellation Constellation

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Constellation @snowmantw @ianwjhalliday @pgilad