Support RestElement #236
Merged
Support RestElement #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
After seeing the test is pased, i'll merge it. |
|
Thank you! |
|
Shouldn't it be |
|
@ArtemGovorov I see you're correct, I will submit another PR that expands coverage to all patterns. |
ef4
added a commit
to ef4/escodegen
that referenced
this pull request
May 28, 2015
This is a followup to estools#236 that brings RestElement into full spec compliance.
ef4
added a commit
to ef4/escodegen
that referenced
this pull request
May 28, 2015
This is a followup to estools#236 that brings RestElement into full spec compliance.
|
That's a spec bug. I will submit an estree issue. edit: Oops, I was thinking only of ArrayBindingPattern, not of ArrayAssignmentPattern. |
|
If it's a bug, it seems to already be implemented in multiple places. esprima supports it, and babel (uses acorn?) supports it too. |
|
See my edit above. I made a mistake. |
ArtemGovorov
pushed a commit
to wallabyjs/escodegen
that referenced
this pull request
May 18, 2016
This is a followup to estools#236 that brings RestElement into full spec compliance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #225.