Super class expression parenthesis #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with escodegen/master
|
@michaelficarra need your review |
|
@michaelficarra ping |
escodegen.js
Outdated
| @@ -1145,7 +1145,17 @@ | |||
| result = join(result, this.generateExpression(stmt.id, Precedence.Sequence, E_TTT)); | |||
| } | |||
| if (stmt.superClass) { | |||
| fragment = join('extends', this.generateExpression(stmt.superClass, Precedence.Assignment, E_TTT)); | |||
| var superClassExpression = this.generateExpression(stmt.superClass, Precedence.Assignment, E_TTT); | |||
There was a problem hiding this comment.
None of the rest of this is necessary. ClassHeritage is a LeftHandSideExpression, not an AssignmentExpression. We should just replace Precedence.Assignment on this line with Precedence.Unary.
There was a problem hiding this comment.
It works, thank you
|
@michaelficarra fixed |
michaelficarra
approved these changes
Jan 10, 2020
bizob2828
pushed a commit
to Contrast-Security-OSS/escodegen
that referenced
this pull request
Apr 2, 2020
* Added parenthesis for some `superClass` expressions * Simplify logic to enable super class expression parenthesis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes javascript-obfuscator/javascript-obfuscator#326