-
Notifications
You must be signed in to change notification settings - Fork 15
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
materialize: boilerplate validator recommends explicit projections am…
…ong ambiguous fields A common case for user-defined projections are to change the capitalization of a field. For systems that do not allow identical-except-for-capitalization named fields, this is unfortunate because the user-defined explicit projection is currently getting marked as optional even if it would otherwise be recommended, since the field names only differ in capitalization. This change has us recommend explicit projections if they would otherwise be recommended even if their field name is ambiguous with others. It is relatively simple to do so since the Flow build process will not allow projected field names that differ only in capitalization, so we know if there is an explicit projection it's the only one with those case-insensitive characters.
- Loading branch information
1 parent
5c2a4cb
commit 0008448
Showing
27 changed files
with
56 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+0 Bytes
(100%)
materialize-boilerplate/testdata/apply/generated_specs/add-new-binding.flow.proto
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
materialize-boilerplate/testdata/apply/generated_specs/add-new-required.flow.proto
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
materialize-boilerplate/testdata/apply/generated_specs/base.flow.proto
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
materialize-boilerplate/testdata/apply/generated_specs/make-nullable.flow.proto
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
materialize-boilerplate/testdata/apply/generated_specs/remove-required.flow.proto
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
materialize-boilerplate/testdata/apply/generated_specs/replace-original-binding.flow.proto
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+0 Bytes
(100%)
materialize-boilerplate/testdata/validate/generated_specs/alternate-root.flow.proto
Binary file not shown.
Binary file modified
BIN
+329 Bytes
(110%)
materialize-boilerplate/testdata/validate/generated_specs/ambiguous-fields.flow.proto
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
materialize-boilerplate/testdata/validate/generated_specs/base.flow.proto
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
materialize-boilerplate/testdata/validate/generated_specs/fewer-fields.flow.proto
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
materialize-boilerplate/testdata/validate/generated_specs/incompatible-changes.flow.proto
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
materialize-boilerplate/testdata/validate/generated_specs/increment-backfill.flow.proto
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
materialize-boilerplate/testdata/validate/generated_specs/long-fields.flow.proto
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
materialize-boilerplate/testdata/validate/generated_specs/nullable-key.flow.proto
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
...erplate/testdata/validate_apply_test_cases/generated_specs/add-and-remove-many.flow.proto
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
...erplate/testdata/validate_apply_test_cases/generated_specs/add-single-optional.flow.proto
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
materialize-boilerplate/testdata/validate_apply_test_cases/generated_specs/base.flow.proto
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
...lerplate/testdata/validate_apply_test_cases/generated_specs/big-schema-changed.flow.proto
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
...erplate/testdata/validate_apply_test_cases/generated_specs/big-schema-nullable.flow.proto
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
...lize-boilerplate/testdata/validate_apply_test_cases/generated_specs/big-schema.flow.proto
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
...lerplate/testdata/validate_apply_test_cases/generated_specs/challenging-fields.flow.proto
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
...late/testdata/validate_apply_test_cases/generated_specs/remove-single-optional.flow.proto
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
...late/testdata/validate_apply_test_cases/generated_specs/remove-single-required.flow.proto
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters