Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

materialize-sql: close client in Validate #1402

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Conversation

mdibaiee
Copy link
Member

@mdibaiee mdibaiee commented Mar 22, 2024

Description:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

databricks driver loads files to memory in full, causing OOM issues.
This is a temporary measure until we fix  this
Copy link
Member

@williamhbaker williamhbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It would not seem unreasonable to me to lower the uploadConcurrency down to 1 just to be sure we don't still get OOMs until the proper fix is merged, but if 3 works that's fine too.

@mdibaiee mdibaiee merged commit 6f6b4f3 into main Mar 22, 2024
44 of 45 checks passed
@mdibaiee mdibaiee deleted the mahdi/db-client-connections branch March 22, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants