materialize-redshift: fix logging of Store bindings with no data #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamhbaker
added
the
change:unplanned
jgraettinger
approved these changes
Oct 8, 2024
materialize-redshift/driver.go
Outdated
| if _, err := txn.Exec(ctx, b.createStoreTableSQL); err != nil { | ||
| return fmt.Errorf("creating store table: %w", err) | ||
| } | ||
| if b.hasStores { |
There was a problem hiding this comment.
nit: can reduce indentation via:
if !b.hasStores {
// Pass.
} else if b.mustMerge {
...
} else {
...
}
We were always calling `FinishedResourceCommit` for bindings even if they had no data, which was resulting in bogus log lines. This fixes the logic to not invoke the logging mechanisms for bindings with no data.
williamhbaker
force-pushed
the
wb/redshift-log-fix
branch
from
df74b8f
to
bf3e7df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We were always calling
FinishedResourceCommitfor bindings even if they had no data, which was resulting in bogus log lines. This fixes the logic to not invoke the logging mechanisms for bindings with no data.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is