Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-mysql: More connection error logging #2031

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

willdonnelly
Copy link
Member

@willdonnelly willdonnelly commented Oct 8, 2024

Description:

I hate this TLS vs non-TLS connection retrying thing and how it results in two distinct errors, let's just make sure to log both so I can at least figure out what went wrong in all cases.


This change is Reviewable

I hate this TLS vs non-TLS connection retrying thing and how it
results in two distinct errors, let's just make sure to log both
so I can at least figure out what went wrong in all cases.
@willdonnelly willdonnelly added the change:unplanned Unplanned change, useful for things like doc updates label Oct 8, 2024
@willdonnelly willdonnelly requested a review from a team October 8, 2024 21:14
Copy link
Member

@psFried psFried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willdonnelly willdonnelly merged commit 1019b0e into main Oct 8, 2024
50 of 52 checks passed
@willdonnelly willdonnelly deleted the wgd/mysql-errors-20241008 branch October 8, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:unplanned Unplanned change, useful for things like doc updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants