source-mysql: Stop logging scary collation error messages #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't an error, it's not even a warning. We should improve this and track the server default collation as described in the new comment _eventually_, but for now it should suffice to just assume the default MySQL charset here. Since that's what we already did, the only real impact of this change is to change the log message and severity in the specific case where the collation name is `""`.
willdonnelly
added
the
change:unplanned
mdibaiee
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This isn't an error, it's not even a warning. We should improve this and track the server default collation as described in the new comment eventually, but for now it should suffice to just assume the default MySQL charset here.
Since that's what we already did, the only real impact of this change is to change the log message and severity in the specific case where the collation name is
"".Notes for reviewers:
This is a bit of a stopgap until I have time to add the aforementioned "keep track of the server default collation and use it here" logic. But it's a stopgap that prevents us logging dozens or hundreds of scary looking error messages which users might see and be justifiably concerned by, when really this is totally fine and benign in basically all circumstances.
This change is