source-mysql: Fix some benign error/warnings that get logged #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdonnelly
added
the
change:unplanned
The collation families `utf8_whatever` and `ascii_whatever` are explicitly added to the charsets table so we stop logging errors reading `unknown charset for collation, assuming UTF-8` and just do that without complaining because UTF-8 is in fact correct. (This requires another minor tweak, because the way we match up a collation name to a character set is by simple prefix matching, and `utf8` is a prefix of the `utf8mb3` and `utf8mb4` collations. But a collation name is actually `<charset>_<comparisonRule>` with an underscore, so to fix that we just have to do a prefix match including that trailing underscore. This should still work the same for all collation names that actually exist.) The `replication connected without TLS` log message is downgraded from WARN to INFO to match the main (non-replication) connection logging. Between these fixes, that's all the main sources of errors and warnings in our production MySQL tasks, so hopefully that will be much less noisy to keep an eye on in the future. This fixes #2056
willdonnelly
force-pushed
the
wgd/mysql-errors-20241015
branch
from
f814aa9
to
671e4f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The collation families
utf8_whateverandascii_whateverare explicitly added to the charsets table so we stop logging errors readingunknown charset for collation, assuming UTF-8and just do that without complaining because UTF-8 is in fact correct.The
replication connected without TLSlog message is downgraded from WARN to INFO to match the main (non-replication) connection logging.Between these fixes, that's all the main sources of errors and warnings in our production MySQL tasks, so hopefully that will be much less noisy to keep an eye on in the future.
This fixes #2056
This change is