materialize-motherduck: use the reserved words list from duckdb_keywords()
#2084
+262
−290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After I approved, I noticed that the snapshot test failed. It probably just needs updated due to the updated reserved words list. |
…ords()` This seems to be a more complete list of words that need quoted, since we have found that column names like `end` don't work without quotes, and that is on the list output from `duckdb_keywords()`.
williamhbaker
force-pushed
the
wb/md-more-quotes
branch
from
9d5a8a9
to
3cf5f78
Compare
Those table creation snapshots in the e2e tests get me every time I try to do something like this and assume that there coulnd't possibly be any other snapshots to update after I finish updating the multitudes in the main connector folder...should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This seems to be a more complete list of words that need quoted, since we have found that column names like
enddon't work without quotes, and that is on the list output fromduckdb_keywords().Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is