fix: flowctl catalog does need pagination after all
#1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshearer
added
the
change:unplanned
jshearer
force-pushed
the
jshearer/flowctl_catalog_pagination
branch
from
4629768
to
ea0c5ae
Compare
Was having a weird issue where `flowctl catalog pull-specs --captures=true --collections=true` wasn't returning any captures, but `flowctl catalog pull-specs --captures=true --collections=false` was, and realized that the first command was returning exactly 1001 specs. Turns out that even though we're paginating the inputs, we still need to paginate the queries themselves.
jshearer
force-pushed
the
jshearer/flowctl_catalog_pagination
branch
from
ea0c5ae
to
52e9d99
Compare
|
Updated to remove incorrect comment:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I was having a weird issue where
flowctl catalog pull-specs --captures=true --collections=truewasn't returning any captures, butflowctl catalog pull-specs --captures=true --collections=falsewas, and realized that the first command was returning 1001 specs, which is suspiciously close to PostgREST's max row limit. Turns out that even though we're paginating the inputs, we still need to paginate the queries themselves.Existing
flowctlUpdated
flowctlThis change is