dekaf: Fix Fetch encoding issue for some versions of librdkafka
#1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshearer
force-pushed
the
jshearer/dekaf_message_format
branch
from
67902da
to
c7904ec
Compare
|
Confirmed that this fixes the errors, and also fixes the Dekaf build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrongly assumed that
kafka-protocolwould do the right thing when passingNoneto a fetch response's records. It appears that it encodes this with a length of-1, but I found that caused issues when testing locally:It still reads documents when the chunk returns some, but otherwise it logs that error frequently. This fixes it
This change is