improve automations interface
#1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgraettinger
added
the
change:unplanned
A gap of the previous interface is that task polls will often want to make databases changes, and those changes should commit in the same transaction that updates the `internal.tasks` table with messages and state. Introduce an Outcome trait which is applied to Postgres transaction it's given, an to which its returned Action is also applied. This lets the Executor implement an optimistic concurrency workflow and further lets it defer deciding what its polling Action will be until after it verifies its optimistic lock.
jgraettinger
force-pushed
the
johnny/more-automations
branch
from
a522e72
to
233748c
Compare
jgraettinger
changed the title
automationsautomations interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Improve the Executor interface to allow for side-effects which commit with the task poll outcome.
Issue #1697
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is