Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"EtaConfig" is not exported in JSR #295

Closed
pasha-bolokhov opened this issue Jul 19, 2024 · 2 comments
Closed

"EtaConfig" is not exported in JSR #295

pasha-bolokhov opened this issue Jul 19, 2024 · 2 comments

Comments

@pasha-bolokhov
Copy link
Contributor

While you can do

import type { EtaConfig } from "https://deno.land/x/eta@v3.4.0/src/config.ts";

you can't do

import type { EtaConfig } from "jsr:@eta-dev/eta@3.4.0"

because it is not being currently exported…

Please export it
@nebrelbug
Copy link
Collaborator

Good catch! I don't have time for a fix atm but I'd be happy to merge a PR!

pasha-bolokhov added a commit to pasha-bolokhov/eta that referenced this issue Jul 23, 2024
@pasha-bolokhov
feat: expose "Options" and "EtaConfig" types (eta-dev#295)
c5445c9
pasha-bolokhov added a commit to pasha-bolokhov/eta that referenced this issue Jul 23, 2024
@pasha-bolokhov
feat: expose "Options" and "EtaConfig" types (eta-dev#295)
09de52f
nebrelbug pushed a commit that referenced this issue Aug 7, 2024
@pasha-bolokhov
export "Options" and "EtaConfig" types in JSR (#295) (#297)
f468e20
@pasha-bolokhov
Copy link
Contributor Author

works now in 3.5.0 after the merge, thanks!

@apiiro-snyk apiiro-snyk mentioned this issue Sep 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pasha-bolokhov @nebrelbug