Clarification du code custom Telemetry AppSignal Ecto #4280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When encountering #4279, I initially wondered if this could impact our metrics (by detaching the corresponding handler). But it turns out this handler is solely focused on AppSignal custom Ecto integration. Also renaming the handler itself, since it shows up in the logs.
thbar
added
the
dette technique
ptitfred
approved these changes
Oct 29, 2024
|
Merci @ptitfred pour la review. Je déploie et j'irai jeter un oeil dans AppSignal après. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
En lien avec:
Et vu que c'était peu clair pour moi, je clarifie le code sur les points suivants:
Vu que le code correspondant n'est pas testé et pas simple à tester en pratique, j'ai testé en local à la main (dans
handle_event) avec unIO.inspect(measurements, IEx.inspect_opts()), aucun souci détecté, ce qui veut dire que le handler est bien enregistré et fonctionne (point important car ceci n'est pas testé à ma connaissance actuellement).