Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the workflow to check goimport items #435

Closed
ahrtr opened this issue Mar 22, 2023 · 2 comments · Fixed by #451
Closed

Improve the workflow to check goimport items #435

ahrtr opened this issue Mar 22, 2023 · 2 comments · Fixed by #451
Assignees
@jmhbnz
Labels
area/testing good first issue

Comments

@ahrtr
Copy link
Member

ahrtr commented Mar 22, 2023

See #433 (comment)
@ahrtr
Copy link
Member Author

ahrtr commented Mar 22, 2023

FYI. etcd-io/etcd#15485

@ahrtr ahrtr mentioned this issue Mar 22, 2023
Merged
@jmhbnz jmhbnz mentioned this issue Apr 5, 2023
Merged
@jmhbnz
Copy link
Member

jmhbnz commented Apr 5, 2023

/assign @jmhbnz

I've opened #451 to try and fix this 🙏🏻

@ahrtr ahrtr closed this as completed in #451 Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmhbnz jmhbnz

Labels
area/testing good first issue
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add verification of go imports when running make fmt
2 participants
@ahrtr @jmhbnz