Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add verification of go imports when running make fmt #451

Merged
merged 1 commit into from
Apr 6, 2023
Merged

test: add verification of go imports when running make fmt #451

merged 1 commit into from
Apr 6, 2023

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Apr 5, 2023

Workflows for bbolt run make fmt however this currently doesn't include a goimports check.

Let's fix that.

Fixes #435

@jmhbnz jmhbnz changed the title Add verification of go imports when running make fmt test: add verification of go imports when running make fmt Apr 5, 2023
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @jmhbnz

Makefile Outdated Show resolved Hide resolved
Signed-off-by: James Blair <mail@jamesblair.net>
@ahrtr ahrtr merged commit 35ff2b3 into etcd-io:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Improve the workflow to check goimport items
3 participants