Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The database init and grow operations still used fsync even when
NoSync was set, on the grounds that these operations are comparatively
rare and it makes sense to want them to be more reliable even at
some marginal cost in speed.
But if you're doing tests on something which happens to use
boltdb lightly, so it creates databases but barely touches them, this
can result in hundreds and hundreds of fsyncs, possibly in parallel,
and that becomes expensive.
Worth noting: Yes, it's intentional that the grow() case is using
db.file.Sync() rather than fdatasync(). On some platforms, fdatasync()
may not cause filesystem metadata updates to get flushed, just raw
file data block updates. We optimistically hope that (File).Sync() will
do the right thing.