Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor worker/operation and support Delete operation #469

Merged
merged 1 commit into from
Apr 24, 2023
Merged

test: refactor worker/operation and support Delete operation #469

merged 1 commit into from
Apr 24, 2023

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Apr 23, 2023

  1. Simplify the worker to make it more generic, and can execute different operations;
  2. Support Delete operation

concurrent_test.go Outdated Show resolved Hide resolved
concurrent_test.go Outdated Show resolved Hide resolved
@ahrtr
Copy link
Member Author

ahrtr commented Apr 23, 2023

@ahrtr
Copy link
Member Author

ahrtr commented Apr 23, 2023

cc @tjungblu

Copy link
Member

@serathius serathius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment above.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
@ahrtr
Copy link
Member Author

ahrtr commented Apr 24, 2023

Comment above.

Resolved. PTAL

@tjungblu
Copy link
Contributor

lgtm (non-binding). Shall we maybe also add some basic linearizability tests for bbolt?

@serathius
Copy link
Member

Looks great! thanks.

@ahrtr ahrtr merged commit b312285 into etcd-io:master Apr 24, 2023
@ahrtr
Copy link
Member Author

ahrtr commented Apr 24, 2023

lgtm (non-binding). Shall we maybe also add some basic linearizability tests for bbolt?

The test case is testing a local library instead of a distributed system, so I don't think it needs test linearizability. FYI. #455 (comment)

@serathius
Copy link
Member

FYI Linearizability is property of concurrent objects, not necessarily distributed systems. https://jepsen.io/consistency/models/linearizable. You can apply it to any concurrent primitive, including semaphores, locks, concurrent maps and transaction key-value stores like bbolt.

@tjungblu
Copy link
Contributor

Linearizability is property of concurrent objects.

Exactly, a distributed system is not that much different than the concurrency on your multi-core CPU.

I don't think it needs test linearizability

Somewhat agreed, it's not a strict requirement for bbolt to be linearizable to make etcd linearizable. But does it hurt to add it? Worst case we waste some dev time, best case we find some issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants