fix:change keysCommand default format auto #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elbehery
commented
Nov 6, 2023
cmd/bbolt/main_test.go
Outdated
| key := fmt.Sprintf("%s-%d", name, i) | ||
| if err := b.Put([]byte(key), []byte{0}); err != nil { | ||
| for _, k := range []int64{10001, 10002} { | ||
| if err := b.Put(convertInt64IntoBytes(t, k), []byte{0}); err != nil { |
Elbehery
force-pushed
the
keysCommand_default_format_auto
branch
3 times, most recently
from
0d8163d to
d641cad
Compare
|
@ahrtr I updated this accordingly, ptal 👍🏽 |
Elbehery
force-pushed
the
keysCommand_default_format_auto
branch
from
d641cad to
337eafd
Compare
|
/assign @ahrtr |
|
@fuweid would appreciate your review :) |
ahrtr
reviewed
Nov 8, 2023
cmd/bbolt/main_test.go
Outdated
| @@ -677,3 +709,11 @@ func convertInt64IntoBytes(num int64) []byte { | |||
| n := binary.PutVarint(buf, num) | |||
| return buf[:n] | |||
| } | |||
|
|
|||
| func convertInt64IntoBytesString(nums ...int64) string { | |||
There was a problem hiding this comment.
Suggested change
| func convertInt64IntoBytesString(nums ...int64) string { | |
| func convertInt64KeysIntoHexString(nums ...int64) string { |
cmd/bbolt/main_test.go
Outdated
| t.Logf("creating test bucket %s", tc.testBucket) | ||
| b, bErr := tx.CreateBucketIfNotExists([]byte(tc.testBucket)) | ||
| if bErr != nil { | ||
| return fmt.Errorf("error creating test bucket '%s': '%v'", tc.testBucket, bErr) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("error creating test bucket '%s': '%v'", tc.testBucket, bErr) | |
| return fmt.Errorf("error creating test bucket %q: %v", tc.testBucket, bErr) |
|
Please also rebase this PR. |
Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
Elbehery
force-pushed
the
keysCommand_default_format_auto
branch
from
337eafd to
09dd42f
Compare
|
@ahrtr done 👍🏽 |
|
Please update the readme in a followup PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes keysCommand default format from ascii-encoded to auto
resolves ##588
cc @ahrtr