Ensure a cursor can continue to iterate elements in reverse direction by call Next when it has already reached the beginning #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrtr
force-pushed
the
cursor_20240421
branch
2 times, most recently
from
17381d8
to
7bbb813
Compare
|
@fuweid Please take a look, and let me know if you have any comment, thx |
|
Hi @ahrtr I'm OOO until Thursday. Will check this in this week. Sorry for that |
…iterate elements in reverse direction after it has reached to the first element Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
… by call Next when it has already reached the beginning Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
fuweid
reviewed
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #733