Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.3] Bump go toolchain to 1.22.6 #822

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

henrybear327
Copy link
Contributor

Reference:
- etcd-io/etcd#18443

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@henrybear327 henrybear327 changed the title Bump go toolchain to 1.22.6 [release-1.3] Bump go toolchain to 1.22.6 Aug 14, 2024
Reference:
- https://github.com/golangci/golangci-lint/releases/tag/v1.60.1

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahrtr, henrybear327

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 8c9b349 into etcd-io:release-1.3 Aug 16, 2024
10 checks passed
@henrybear327 henrybear327 deleted the 1.3_go/1.22.0 branch August 16, 2024 23:39
@@ -1,8 +1,8 @@
module go.etcd.io/bbolt

go 1.21
go 1.22

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the requirement in this project to bump minimal go version to 1.22?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @crazy-max, the rationale is documented here!

Copy link

@crazy-max crazy-max Sep 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not sure why. It should be the minimal required version for this module: https://go.dev/ref/mod#go-mod-file-go

The go directive sets the minimum version of Go required to use this module.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivanvc please correct me if I am wrong.

The main idea is the support: Each major Go release is supported until there are two newer major releases. [1]. Thus, we are bumping the minimal required version to make sure we are not on the unsupported Go release.

Reference:
[1] https://go.dev/doc/devel/release

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @crazy-max, thanks for raising awareness of this. We have our Golang version usage documented in the etcd-io/etcd repository: https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/dependency_management.md#golang-versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving this a second thought. We may want to have a different policy for projects that are libraries like bbolt and raft. Should we consider staying on the oldest supported Go version until they drop support for it? @ahrtr WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

staying on the oldest supported Go version until they drop support for it

YES, that's the policy we have been following.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, my bad. I got confused with the minors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants