-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info on how to iterate over existing buckets #828
Conversation
Thanks for the PR. Please signoff the commit. Read https://github.com/etcd-io/bbolt/pull/828/checks?check_run_id=29221691728 |
8b60bf6
to
cc78c83
Compare
/ok-to-test |
Hi @ErikKalkoken, thanks for your contribution. Could you please sign your commit, as requested by Ben? So the developer certificate of origin (DCO) check passes, i.e:
Thanks! Please refer to: https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#commit-your-change |
Signed-off-by: ErikKalkoken <erik.kalkoken@gmail.com>
Co-authored-by: Benjamin Wang <benjamin.wang@broadcom.com> Signed-off-by: ErikKalkoken <erik.kalkoken@gmail.com>
cc78c83
to
77a08ff
Compare
Signed-off-by: ErikKalkoken <erik.kalkoken@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ErikKalkoken The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This adds a short description on how to iterate over existing buckets to the README.
This should be helpful for people looking for this particular information (e.g. see #327).