Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info on how to iterate over existing buckets #828

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

ErikKalkoken
Copy link
Contributor

This adds a short description on how to iterate over existing buckets to the README.

This should be helpful for people looking for this particular information (e.g. see #327).

README.md Outdated Show resolved Hide resolved
@ahrtr
Copy link
Member

ahrtr commented Aug 25, 2024

Thanks for the PR.

Please signoff the commit. Read https://github.com/etcd-io/bbolt/pull/828/checks?check_run_id=29221691728

@ivanvc
Copy link
Member

ivanvc commented Aug 26, 2024

/ok-to-test

@ivanvc
Copy link
Member

ivanvc commented Aug 26, 2024

Hi @ErikKalkoken, thanks for your contribution. Could you please sign your commit, as requested by Ben? So the developer certificate of origin (DCO) check passes, i.e:

git rebase HEAD~1 --signoff
git push --force

Thanks!

Please refer to: https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#commit-your-change

ErikKalkoken and others added 2 commits August 26, 2024 12:35
Signed-off-by: ErikKalkoken <erik.kalkoken@gmail.com>
Co-authored-by: Benjamin Wang <benjamin.wang@broadcom.com>
Signed-off-by: ErikKalkoken <erik.kalkoken@gmail.com>
README.md Outdated Show resolved Hide resolved
Signed-off-by: ErikKalkoken <erik.kalkoken@gmail.com>
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ErikKalkoken

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 0cecda6 into etcd-io:main Aug 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants