Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: enable ok-to-test for release-1.3 PRs #841

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Oct 8, 2024

Follow-up on #837 (comment).

Is this all we need to enable this to work with the release-1.3 branch?

Signed-off-by: Ivan Valdes <ivan@vald.es>
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

THanks

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit fcbb5b6 into etcd-io:main Oct 14, 2024
18 checks passed
@ivanvc ivanvc deleted the enable-ok-to-test-in-release-1.3 branch October 15, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants