Skip to content

Commit

Permalink
integration : fix TestTLSClientCipherSuitesMismatch in go1.13
Browse files Browse the repository at this point in the history
In go1.13, the TLS13 is enablled by default, and as per go1.13 release notes :
TLS 1.3 cipher suites are not configurable. All supported cipher suites are safe,
and if PreferServerCipherSuites is set in Config the preference order is based
on the available hardware.

Fixing the test case for go1.13 by limiting the TLS version to TLS12
  • Loading branch information
vimalk78 committed Sep 6, 2019
1 parent e2035ba commit 2648a36
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions integration/v3_tls_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ func testTLSCipherSuites(t *testing.T, valid bool) {
if err != nil {
t.Fatal(err)
}
// go1.13 enables TLS13 by default, and in TLS13, cipher suites are not configurable
// setting Max TLS version to TLS12 for go1.13
cc.MaxVersion = tls.VersionTLS12
cli, cerr := clientv3.New(clientv3.Config{
Endpoints: []string{clus.Members[0].GRPCAddr()},
DialTimeout: time.Second,
Expand Down

0 comments on commit 2648a36

Please sign in to comment.