Skip to content

Commit

Permalink
Simplify etcd image release process.
Browse files Browse the repository at this point in the history
Only test and publish the single multi arch image.

Signed-off-by: James Blair <mail@jamesblair.net>
  • Loading branch information
jmhbnz committed Mar 31, 2023
1 parent 6a995d2 commit 4806d8f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 20 deletions.
7 changes: 0 additions & 7 deletions scripts/release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -258,13 +258,6 @@ main() {
log_warning "login failed, retrying"
done

for TARGET_ARCH in "amd64" "arm64" "ppc64le" "s390x"; do
log_callout "Pushing container images to quay.io ${RELEASE_VERSION}-${TARGET_ARCH}"
maybe_run docker push "quay.io/coreos/etcd:${RELEASE_VERSION}-${TARGET_ARCH}"
log_callout "Pushing container images to gcr.io ${RELEASE_VERSION}-${TARGET_ARCH}"
maybe_run docker push "gcr.io/etcd-development/etcd:${RELEASE_VERSION}-${TARGET_ARCH}"
done

log_callout "Creating manifest-list (multi-image)..."

for TARGET_ARCH in "amd64" "arm64" "ppc64le" "s390x"; do
Expand Down
15 changes: 2 additions & 13 deletions scripts/test_images.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,15 @@ if [[ $(go env GOOS) == "darwin" ]]; then
fi

# Pick defaults based on release workflow
ARCH=$(go env GOARCH)
REPOSITARY=${REPOSITARY:-"gcr.io/etcd-development/etcd"}
REPOSITORY=${REPOSITORY:-"gcr.io/etcd-development/etcd"}
if [ -n "$VERSION" ]; then
# Expected Format: v3.6.99-amd64
TAG=v"${VERSION}"-"${ARCH}"
else
echo "Terminating test, VERSION not supplied"
exit 1
fi
IMAGE=${IMAGE:-"${REPOSITARY}:${TAG}"}
IMAGE=${IMAGE:-"${REPOSITORY}:${TAG}"}

# ETCD related values
RUN_NAME="test_etcd"
Expand Down Expand Up @@ -82,13 +81,3 @@ if [ "${GET}" != "${VALUE}" ]; then
fi

echo "Succesfully tested etcd local image ${TAG}"

for TARGET_ARCH in "amd64" "arm64" "ppc64le" "s390x"; do
ARCH_TAG=v"${VERSION}"-"${TARGET_ARCH}"
IMG_ARCH=$(docker inspect --format '{{.Architecture}}' "${REPOSITARY}:${ARCH_TAG}")
if [ "${IMG_ARCH}" != "$TARGET_ARCH" ];then
echo "Incorrect docker image architecture"
exit 1
fi
echo "Correct Architecture ${ARCH_TAG}"
done

0 comments on commit 4806d8f

Please sign in to comment.