Merge pull request #11862 from gyuho/const

etcdserver: compute max request bytes humanized string once
etcd-io · May 12, 2020 · ab49495 · ab49495
2 parents 5f07d46 + 89a3a24
commit ab49495
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/etcdserver/server.go b/etcdserver/server.go
@@ -104,7 +104,8 @@ const (
 )
 
 var (
-	storeMemberAttributeRegexp = regexp.MustCompile(path.Join(membership.StoreMembersPrefix, "[[:xdigit:]]{1,16}", "attributes"))
+	recommendedMaxRequestBytesString = humanize.Bytes(uint64(recommendedMaxRequestBytes))
+	storeMemberAttributeRegexp       = regexp.MustCompile(path.Join(membership.StoreMembersPrefix, "[[:xdigit:]]{1,16}", "attributes"))
 )
 
 func init() {
@@ -298,7 +299,7 @@ func NewServer(cfg ServerConfig) (srv *EtcdServer, err error) {
 			zap.Uint("max-request-bytes", cfg.MaxRequestBytes),
 			zap.String("max-request-size", humanize.Bytes(uint64(cfg.MaxRequestBytes))),
 			zap.Int("recommended-request-bytes", recommendedMaxRequestBytes),
-			zap.String("recommended-request-size", humanize.Bytes(uint64(recommendedMaxRequestBytes))),
+			zap.String("recommended-request-size", recommendedMaxRequestBytesString),
 		)
 	}