Skip to content

Commit

Permalink
test: skip govet shadow tests for now
Browse files Browse the repository at this point in the history
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
  • Loading branch information
gyuho committed Sep 6, 2019
1 parent 2cab6ed commit d4d57c5
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions test
Original file line number Diff line number Diff line change
Expand Up @@ -460,12 +460,12 @@ function govet_shadow_pass {
# shellcheck disable=SC2206
fmtpkgs=($fmtpkgs)
# Golang 1.12 onwards the experimental -shadow option is no longer available with go vet
go get golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow
go get -v golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow
export PATH=${GOPATH}/bin:${PATH}
shadow_tool=$(which shadow)
vetRes=$(go vet -all -vettool="${shadow_tool}" "${TEST[@]}")
if [ -n "${vetRes}" ]; then
echo -e "govet -all -shadow checking failed:\\n${vetRes}"
echo -e "govet -shadow checking failed:\\n${vetRes}"
exit 255
fi
}
Expand Down Expand Up @@ -617,7 +617,6 @@ function fmt_pass {
goword \
gofmt \
govet \
govet_shadow \
revive \
license_header \
receiver_name \
Expand Down

0 comments on commit d4d57c5

Please sign in to comment.