Merge pull request #19319 from fuweid/fix-19292

*: introduce (*Op) Limit() interface for robustness
etcd-io · Feb 3, 2025 · de82ea2 · de82ea2
2 parents b197332 + 136dfbe
commit de82ea2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/client/v3/op.go b/client/v3/op.go
@@ -106,6 +106,9 @@ func (op Op) RangeBytes() []byte { return op.end }
 // Rev returns the requested revision, if any.
 func (op Op) Rev() int64 { return op.rev }
 
+// Limit returns limit of the result, if any.
+func (op Op) Limit() int64 { return op.limit }
+
 // IsPut returns true iff the operation is a Put.
 func (op Op) IsPut() bool { return op.t == tPut }
 

diff --git a/tests/robustness/client/client.go b/tests/robustness/client/client.go
@@ -88,8 +88,8 @@ func (c *RecordingClient) Do(ctx context.Context, op clientv3.Op) (clientv3.OpRe
 }
 
 func (c *RecordingClient) Get(ctx context.Context, key string, opts ...clientv3.OpOption) (*clientv3.GetResponse, error) {
-	revision := clientv3.OpGet(key, opts...).Rev()
-	return c.Range(ctx, key, "", revision, 0)
+	op := clientv3.OpGet(key, opts...)
+	return c.Range(ctx, key, string(op.RangeBytes()), op.Rev(), op.Limit())
 }
 
 func (c *RecordingClient) Range(ctx context.Context, start, end string, revision, limit int64) (*clientv3.GetResponse, error) {